Remove newly stabilized features #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebrosen
approved these changes
Apr 10, 2019
|
... and I forgot that this affects the minimum supported rustc 🙄. |
|
@jebrosen Rollback? The PR is still open and can be merged at a later date (likely around the time 0.5 comes out). |
|
If you would change the minimum nightly in |
|
Bumped. |
jebrosen
reviewed
Apr 13, 2019
| @@ -1,6 +1,5 @@ | |||
| #![feature(proc_macro_diagnostic, proc_macro_span)] | |||
| #![feature(crate_visibility_modifier)] | |||
| #![feature(transpose_result)] | |||
There was a problem hiding this comment.
This bumps the minimum rustc for codegen, but only to around 2019-01-13. Since there are a few other PRs open that affect the minimum rustc, we can just take care of this when merging to avoid conflicts.
|
Merged in 9b219dd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transpose_resultandtry_fromhave both been stabilized in 1.34. This removes the compiler flags.Related: Compile on stable Rust (#19).