Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opt-out of fetch polyfill #67

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@mydea
Copy link
Contributor

commented Nov 27, 2018

This PR adds a includeFetchPolyfill configuration option, which defaults to true, but can be disabled to not include the fetch polyfill.

IMHO, it would make sense to default this to false, and make this opt-in instead - but that would be a breaking change for a major release.

Fixes #66

@rwjblue

This comment has been minimized.

Copy link
Owner

commented Nov 27, 2018

IMHO, it would make sense to default this to false, and make this opt-in instead - but that would be a breaking change for a major release.

We could also use the browser targets to decide if it is needed...

@mydea

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

I can implement the same changes as here: ember-cli/ember-fetch#173 ?

@rwjblue rwjblue merged commit c4f09fe into rwjblue:master Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue added the enhancement label Jan 18, 2019

@rwjblue

This comment has been minimized.

Copy link
Owner

commented Jan 18, 2019

ember-cli-pretender 3.1.0 published 🎉

@@ -35,6 +35,16 @@ var app = new EmberApp({
});
```

You can also opt out of including the fetch polyfill, if you do not need to run your tests in older browsers:

This comment has been minimized.

Copy link
@xg-wang

xg-wang Feb 17, 2019

Contributor

Should this be "if you do not need to test fetch with pretender"? Since the polyfill is not for older browsers but to make fetch interceptable by pretender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.