New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional ignore directories: #14

Merged
merged 1 commit into from Apr 29, 2015

Conversation

Projects
None yet
3 participants
@xsawyerx
Contributor

xsawyerx commented Apr 27, 2015

(GH #12 for more context.)

# skip "t" - libraries in ./t are test libraries!
# skip "xt" - libraries in ./xt are author test libraries!
# skip "inc" - libraries in ./inc are usually install libraries
# skip "local" - somebody shipped his carton setup!
# skip 'perl5" - somebody shipped her local::lib!
# skip 'fatlib' - App::FatPacker
Add additional ignore directories:
(GH #12 for more context.)

    # skip "t" - libraries in ./t are test libraries!
    # skip "xt" - libraries in ./xt are author test libraries!
    # skip "inc" - libraries in ./inc are usually install libraries
    # skip "local" - somebody shipped his carton setup!
    # skip 'perl5" - somebody shipped her local::lib!
    # skip 'fatlib' - App::FatPacker
@xsawyerx

This comment has been minimized.

Show comment
Hide comment
@xsawyerx

xsawyerx Apr 27, 2015

Contributor

GH #12 also mentions that the default directories are ignored if the distribution's META.{json,yml} file provides something else. From my checks, it doesn't. That means that if a distribution provides "foo" and "bar", the META list's "no_index" will include all the default ones plus "foo" and "bar".

That means #12 can be closed.

Contributor

xsawyerx commented Apr 27, 2015

GH #12 also mentions that the default directories are ignored if the distribution's META.{json,yml} file provides something else. From my checks, it doesn't. That means that if a distribution provides "foo" and "bar", the META list's "no_index" will include all the default ones plus "foo" and "bar".

That means #12 can be closed.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 27, 2015

Coverage Status

Coverage remained the same at 95.6% when pulling eed550d on xsawyerx:pr/additional-ignore-directories into 8e2cfa1 on rwstauner:master.

coveralls commented Apr 27, 2015

Coverage Status

Coverage remained the same at 95.6% when pulling eed550d on xsawyerx:pr/additional-ignore-directories into 8e2cfa1 on rwstauner:master.

@rwstauner rwstauner merged commit eed550d into rwstauner:master Apr 29, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.6%
Details
@rwstauner

This comment has been minimized.

Show comment
Hide comment
@rwstauner

rwstauner Apr 29, 2015

Owner

I didn't realize it, but you're right, it already merges the default dirs in.
I added a test to confirm.
Thanks!

Owner

rwstauner commented Apr 29, 2015

I didn't realize it, but you're right, it already merges the default dirs in.
I added a test to confirm.
Thanks!

rwstauner added a commit that referenced this pull request Apr 29, 2015

v0.926
  - Always add local, perl5, and fatlib to "no_index.directory"
    for consistency with PAUSE.  Closes gh-12 and gh-14.
    Thanks to Sawyer X for the pull-req and the prodding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment