Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: not able to add SubmodelElementCollection to SubmodelElementList #20

Closed
jh-isw opened this issue Dec 14, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@jh-isw
Copy link

jh-isw commented Dec 14, 2023

What happened?

Hello,
I wanted to add a SubmodelElementCollection (SMC) to a SubmodelElementList (SML).

IDTA-01001-3-0 Specification -> Constraint AASd-120 states, that an element of a SML should not have an IdShort. Yet, I can't add a SMC without supplying an IdShort.

Here's the error I get, when supplying no IdShort:

image

Relevant log output

No response

@jh-isw jh-isw added the bug Something isn't working label Dec 14, 2023
@zrgt
Copy link
Collaborator

zrgt commented Dec 17, 2023

Hey @jsw, big thanks for spotting that bug! 🌟 We've fixed it in the latest release, which you can check out here: https://github.com/rwth-iat/aas_manager/releases/tag/7241236642

Because the idShort for all Referables SEs is mandatory except for SEs in SubmodelElementLists, we had to do some hack, such that idShort of SE in SEList can not be provided by the user, but will be generated automatically and removed while serialisation .

Your report helped us a lot. Feel free to report any other issues you come across. It's super helpful and keeps our software getting better. Thanks again!

@zrgt
Copy link
Collaborator

zrgt commented Dec 17, 2023

Fixed in 3ba7942

@zrgt zrgt closed this as completed Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants