fix(state): handle error emission in connect using ErrorHandler

[edbzn]

It's potentially a breaking change as with these changes instantiating RxState outside of Angular injection context will raise the following error:

NG0203: inject() must be called from an injection context such as a constructor, a factory function, a field initializer, or a function used with `EnvironmentInjector#runInContext`. Find more at https://angular.io/errors/NG0203

However, I don't see any good reasons to instantiate RxState outside of a field initializer or a factory function.

Fixes #1536

[nx-cloud]

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit fa72532. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
nx affected:test --parallel --max-parallel=1 --max-workers=2 --ci --code-coverage

✅ Successfully ran 2 targets

• nx build docs
• nx affected:lint --parallel --max-parallel=2 --quiet

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #1553 (246f7e6) into main (0a599db) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 246f7e6 differs from pull request most recent head fa72532. Consider uploading reports for the commit fa72532 to get more accurate results

@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   81.60%   81.62%   +0.01%     
==========================================
  Files         104      104              
  Lines        2229     2231       +2     
  Branches      407      407              
==========================================
+ Hits         1819     1821       +2     
  Misses        332      332              
  Partials       78       78              

Flag	Coverage Δ
state	90.36% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tate/selections/src/lib/accumulation-observable.ts	100.00% <100.00%> (ø)
libs/state/src/lib/rx-state.service.ts	100.00% <100.00%> (ø)

[hoebbelsB]

hello @edbzn thx for the PR :)

I'm not even sure if my comment is actually correct, but I guess we will have a problem with the execution context. If not, please ignore me and I'm going to approve. Sorry, had no time to actually check that, it just came to my mind ^^

[hoebbelsB]

We have to make sure the correct execution context is provided. Not sure if the current solution works if you try to access fields inside the handleError function.

e.g.

class ErrorHandler {
  handleError() {
    if (this.env === 'prod') {
       // do something in prod
    }
  }
}

could we create an test case for that?

Suggested change

	private handleError = inject(ErrorHandler).handleError;
	private accumulator = createAccumulationObservable<T>({
	handleError: this.handleError,
	});
	private errorHandler = inject(ErrorHandler);
	private accumulator = createAccumulationObservable<T>({
	handleError: this.erroHandler.handleError.bind(this.errorHandler),
	});

[edbzn]

I pushed the changes, but the test is failing, I'm not sure to get why. If you have an idea @hoebbelsB.