Skip to content
Browse files

Dialog: Update to 96e5c24 - keyup apparently doesn't work like I thou…

…ght it would everywhere, switching back to keydown.

(cherry picked from commit dfe75e1)
  • Loading branch information...
1 parent 8f16cc3 commit 5d4d40f7be1b0d69060eca228f8fce48d453be7e @gnarf gnarf committed Aug 20, 2011
Showing with 2 additions and 2 deletions.
  1. +1 −1 tests/unit/dialog/dialog_tickets.js
  2. +1 −1 ui/jquery.ui.dialog.js
View
2 tests/unit/dialog/dialog_tickets.js
@@ -14,7 +14,7 @@ asyncTest( "#3123: Prevent tabbing out of modal dialogs", function() {
inputs.eq( 1 ).focus();
equal( document.activeElement, inputs[1], "Focus set on second input" );
- inputs.eq( 1 ).simulate( "keyup", { keyCode: $.ui.keyCode.TAB });
+ inputs.eq( 1 ).simulate( "keydown", { keyCode: $.ui.keyCode.TAB });
setTimeout( checkTab, 2 );
View
2 ui/jquery.ui.dialog.js
@@ -330,7 +330,7 @@ $.widget("ui.dialog", {
// prevent tabbing out of modal dialogs
if ( options.modal ) {
- uiDialog.bind( "keyup.ui-dialog", function( event ) {
+ uiDialog.bind( "keydown.ui-dialog", function( event ) {
if ( event.keyCode !== $.ui.keyCode.TAB ) {
return;
}

0 comments on commit 5d4d40f

Please sign in to comment.
Something went wrong with that request. Please try again.