New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateTranslations: write out `data` not `defaultMessages` #2

Merged
merged 1 commit into from Sep 16, 2015

Conversation

Projects
None yet
2 participants
@alunny
Collaborator

alunny commented Sep 15, 2015

generateTranslations writes out the wrong message format; it writes:

{ "foo": "foo" }

instead of

{ "en": { "foo": "foo" } }

Since the data object is already created (and not used), I assume this was just an error.

@alunny alunny referenced this pull request Sep 15, 2015

Closed

auto-generate messages files #5

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Sep 16, 2015

Owner

Ouch! Thanks

Owner

rxaviers commented Sep 16, 2015

Ouch! Thanks

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Sep 16, 2015

Owner

Could you please sign-off your commit after reading https://github.com/rxaviers/react-globalize-compiler/blob/master/DCO.md? (Feel free to amend and force push)

Owner

rxaviers commented Sep 16, 2015

Could you please sign-off your commit after reading https://github.com/rxaviers/react-globalize-compiler/blob/master/DCO.md? (Feel free to amend and force push)

generateTranslations: write out data
Signed-off-by: Andrew Lunny <alunny@twitter.com>
@alunny

This comment has been minimized.

Show comment
Hide comment
@alunny

alunny Sep 16, 2015

Collaborator

Done!

Collaborator

alunny commented Sep 16, 2015

Done!

@rxaviers rxaviers merged commit d183947 into rxaviers:master Sep 16, 2015

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Sep 16, 2015

Owner

Merged, thanks

Owner

rxaviers commented Sep 16, 2015

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment