New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude react-globalize files from webpack transforms #11

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
2 participants
@alunny
Collaborator

alunny commented Nov 13, 2015

Depends on rxaviers/globalize-webpack-plugin#9 being merged and published as 0.3.0 :)

Show outdated Hide outdated util.js
isReactGlobalizeModule: function(filepath) {
filepath = filepath.split( "/" );
var i = filepath.lastIndexOf("react-globalize");
// 1: path should contain "globalize",

This comment has been minimized.

@rxaviers

rxaviers Nov 17, 2015

Owner

Comment needs update for "..contain "react-globalize".

@rxaviers

rxaviers Nov 17, 2015

Owner

Comment needs update for "..contain "react-globalize".

@alunny

This comment has been minimized.

Show comment
Hide comment
@alunny

alunny Jan 13, 2016

Collaborator

@rxaviers now that the globalize-webpack-plugin change is in, I'm going to merge this and publish a new release.

Since it changes the behavior of the module, I'll give it a minor version bump to 0.4.0.

Collaborator

alunny commented Jan 13, 2016

@rxaviers now that the globalize-webpack-plugin change is in, I'm going to merge this and publish a new release.

Since it changes the behavior of the module, I'll give it a minor version bump to 0.4.0.

@alunny alunny merged commit 46bba49 into rxaviers:master Jan 13, 2016

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Jan 13, 2016

Owner

👍

+55 (16) 98138-1583, skype: rxaviers
http://rafael.xavier.blog.br

Owner

rxaviers commented Jan 13, 2016

👍

+55 (16) 98138-1583, skype: rxaviers
http://rafael.xavier.blog.br

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Jan 19, 2016

Owner

@alunny, this change broke some of my applications (that used react-globalize solely). Please, could you refresh my memory, was it motivated by rxaviers/globalize-webpack-plugin#8? If so, it seems like the correct approach is going to be handling default messages in Globalize, not by this change. What do you think? Thanks.

PS: For clarity, the change in globalize-webpack-plugin is totally fine. I think the problem is to use the filter to skip react-globalize files.

Owner

rxaviers commented Jan 19, 2016

@alunny, this change broke some of my applications (that used react-globalize solely). Please, could you refresh my memory, was it motivated by rxaviers/globalize-webpack-plugin#8? If so, it seems like the correct approach is going to be handling default messages in Globalize, not by this change. What do you think? Thanks.

PS: For clarity, the change in globalize-webpack-plugin is totally fine. I think the problem is to use the filter to skip react-globalize files.

@alunny

This comment has been minimized.

Show comment
Hide comment
@alunny

alunny Jan 19, 2016

Collaborator

Do you have react-globalize in your vendor bundle (in the webpack config), or globalize in the vendor bundle and react-globalize in the app bundle?

I think the filter needs to be there if react-globalize is in the vendor bundle, but causes problems if it's in the app bundle.

Collaborator

alunny commented Jan 19, 2016

Do you have react-globalize in your vendor bundle (in the webpack config), or globalize in the vendor bundle and react-globalize in the app bundle?

I think the filter needs to be there if react-globalize is in the vendor bundle, but causes problems if it's in the app bundle.

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Jan 19, 2016

Owner

I've created a simple example (which probably needs simplifications and improvements) here #12, which shows your update didn't cause any problems. So, please ignore my comment.

PS: I have both globalize and react-globalize in vendors in my app, but I still don't know what's causing the failure. Investigating.

Owner

rxaviers commented Jan 19, 2016

I've created a simple example (which probably needs simplifications and improvements) here #12, which shows your update didn't cause any problems. So, please ignore my comment.

PS: I have both globalize and react-globalize in vendors in my app, but I still don't know what's causing the failure. Investigating.

@alunny

This comment has been minimized.

Show comment
Hide comment
@alunny

alunny Jan 19, 2016

Collaborator

Thanks @rxaviers - I'll have a look at #12 and let you know of any suggestions.

Collaborator

alunny commented Jan 19, 2016

Thanks @rxaviers - I'll have a look at #12 and let you know of any suggestions.

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Jan 19, 2016

Owner

Thank you.

Owner

rxaviers commented Jan 19, 2016

Thank you.

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Mar 14, 2016

Owner

@alunny, FYI I'm finally back to this and so far I've noticed #14.

Owner

rxaviers commented Mar 14, 2016

@alunny, FYI I'm finally back to this and so far I've noticed #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment