New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to disable : "Do not merge with previous post" #13

Closed
Galixte opened this Issue Feb 9, 2015 · 13 comments

Comments

Projects
None yet
2 participants
@Galixte
Contributor

Galixte commented Feb 9, 2015

Hi,

to follow with this thread #10.

Could you make in sort to give the possibility to disable this permission for users registred : Do not merge with previous post ?

@rxu

This comment has been minimized.

Show comment
Hide comment
@rxu

rxu Feb 15, 2015

Owner

I guess that's possible in some of the next versions. This would require adding a special permissions as well as appending it to the standard roles.

Owner

rxu commented Feb 15, 2015

I guess that's possible in some of the next versions. This would require adding a special permissions as well as appending it to the standard roles.

@Galixte

This comment has been minimized.

Show comment
Hide comment
@Galixte

Galixte Feb 20, 2015

Contributor

Cool thanks 👍

Contributor

Galixte commented Feb 20, 2015

Cool thanks 👍

@Galixte

This comment has been minimized.

Show comment
Hide comment
@Galixte

Galixte Apr 8, 2015

Contributor

Hi @rxu,

could you take a look ?

Contributor

Galixte commented Apr 8, 2015

Hi @rxu,

could you take a look ?

@rxu

This comment has been minimized.

Show comment
Hide comment
@rxu

rxu Apr 9, 2015

Owner

@Galixte TBH, I'm not sure how should this be impltmented. It can be either global config option, or a forum-based permission (or even both).

Owner

rxu commented Apr 9, 2015

@Galixte TBH, I'm not sure how should this be impltmented. It can be either global config option, or a forum-based permission (or even both).

@Galixte

This comment has been minimized.

Show comment
Hide comment
@Galixte

Galixte Apr 11, 2015

Contributor

Hi @rxu,

for me this extension is a good thing to limit the flood. This option:

Posts merging interval:
If a user submit more than 2 posts in this time period, posts will be merged into one post. Information about the time passed from the previous post submitting will be added (for each post). Leave blank or set 0 to disable posts merging.

To permit to control the intervalls between two distinct messages from same author. If the user (author) has the possibility to override this option, i don't see the utility.

Contributor

Galixte commented Apr 11, 2015

Hi @rxu,

for me this extension is a good thing to limit the flood. This option:

Posts merging interval:
If a user submit more than 2 posts in this time period, posts will be merged into one post. Information about the time passed from the previous post submitting will be added (for each post). Leave blank or set 0 to disable posts merging.

To permit to control the intervalls between two distinct messages from same author. If the user (author) has the possibility to override this option, i don't see the utility.

@rxu

This comment has been minimized.

Show comment
Hide comment
@rxu

rxu Apr 12, 2015

Owner

@Galixte This feature has a long life since 3.0 MOD, so the option to override merging (on per posts/topics/forums basis) has came from the users demands because there're cases when you just don't want to merge posts for some reason.
I guess overriding feature can be limited via global setting plus forum based permission.

Owner

rxu commented Apr 12, 2015

@Galixte This feature has a long life since 3.0 MOD, so the option to override merging (on per posts/topics/forums basis) has came from the users demands because there're cases when you just don't want to merge posts for some reason.
I guess overriding feature can be limited via global setting plus forum based permission.

@Galixte

This comment has been minimized.

Show comment
Hide comment
@Galixte

Galixte Apr 12, 2015

Contributor

Hi @rxu,

i'm Ok with you.

Contributor

Galixte commented Apr 12, 2015

Hi @rxu,

i'm Ok with you.

@Galixte

This comment has been minimized.

Show comment
Hide comment
@Galixte

Galixte Jun 5, 2015

Contributor

Hi @rxu,

could take a look to implement this feature ?

Contributor

Galixte commented Jun 5, 2015

Hi @rxu,

could take a look to implement this feature ?

@rxu

This comment has been minimized.

Show comment
Hide comment
@rxu

rxu Jun 5, 2015

Owner

@Galixte Waiting for the bugfix phpbb/phpbb#3551

Owner

rxu commented Jun 5, 2015

@Galixte Waiting for the bugfix phpbb/phpbb#3551

@Galixte

This comment has been minimized.

Show comment
Hide comment
@Galixte

Galixte Jun 5, 2015

Contributor

Of course, thanks !

Contributor

Galixte commented Jun 5, 2015

Of course, thanks !

@Galixte

This comment has been minimized.

Show comment
Hide comment
@Galixte

Galixte Jun 22, 2015

Contributor

Hi @rxu,

it’s merged, could take a look to implement this feature, please ?

Contributor

Galixte commented Jun 22, 2015

Hi @rxu,

it’s merged, could take a look to implement this feature, please ?

@rxu

This comment has been minimized.

Show comment
Hide comment
@rxu

rxu Sep 19, 2015

Owner

Implemented with d2b9b41. Thanks.

Owner

rxu commented Sep 19, 2015

Implemented with d2b9b41. Thanks.

@rxu rxu closed this Sep 19, 2015

@Galixte

This comment has been minimized.

Show comment
Hide comment
@Galixte

Galixte Sep 19, 2015

Contributor

Thanks to you rxu ;)

Contributor

Galixte commented Sep 19, 2015

Thanks to you rxu ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment