diff --git a/libdeno/binding.cc b/libdeno/binding.cc index 8f601412f81c5..2a68d89aae231 100644 --- a/libdeno/binding.cc +++ b/libdeno/binding.cc @@ -182,25 +182,17 @@ void PromiseRejectCallback(v8::PromiseRejectMessage promise_reject_message) { d->pending_promise_map_.emplace(std::piecewise_construct, std::make_tuple(promise_id), std::make_tuple(d->isolate_, error)); - // rejectMap.set(promise, (error as Error).stack || - // "RejectWithNoHandler"); break; case v8::kPromiseHandlerAddedAfterReject: - // unhandled event cancelled d->pending_promise_map_.erase(promise_id); - // rejectMap.delete(promise); break; case v8::kPromiseRejectAfterResolved: - // Should not warn. See #1272 - // d->pending_promise_events_++; break; case v8::kPromiseResolveAfterResolved: - // d->pending_promise_events_++; - // error is string here - // otherErrorMap.set(promise, `Promise warning: ${error as string}`); + // Should not warn. See #1272 break; default: diff --git a/src/main.rs b/src/main.rs index abf12c6d5dd0f..cdb7d8dd0611c 100644 --- a/src/main.rs +++ b/src/main.rs @@ -73,7 +73,7 @@ impl log::Log for Logger { fn print_err_and_exit(err: js_errors::JSError) { // TODO Currently tests depend on exception going to stdout. It should go - // to stderr. + // to stderr. https://github.com/denoland/deno/issues/964 println!("{}", err.to_string()); std::process::exit(1); }