Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 objects with white spaces are not supported #40

Closed
yigal-rozenberg opened this issue Dec 2, 2019 · 2 comments · Fixed by #41
Closed

S3 objects with white spaces are not supported #40

yigal-rozenberg opened this issue Dec 2, 2019 · 2 comments · Fixed by #41
Assignees
@c-w

Comments

@yigal-rozenberg
Copy link

When clicking on a S3 object (file) that includes white spaces there is a 404 error.
Looks like the URLs need to be decoded and escaped characters need to be replaced in the document view code.
@c-w c-w mentioned this issue Dec 10, 2019
Merged
@c-w
Copy link
Collaborator

c-w commented Dec 10, 2019

Thanks for reporting this. The behavior was fixed for paths in #38 and now for document names in #41.

@c-w c-w closed this as completed in #41 Dec 10, 2019
@c-w c-w self-assigned this Dec 10, 2019
@c-w
Copy link
Collaborator

c-w commented Dec 10, 2019

@yigal-rozenberg A fix for this has been published in version 0.5.4 (PyPI, DockerHub).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c-w c-w

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rendering of doc paths with URL characters ryan-roemer/django-cloud-browser
2 participants
@c-w @yigal-rozenberg