Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install on Python >= 3.6 #18

Merged
merged 3 commits into from May 23, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Collaborator

commented May 18, 2019

As discussed in #17, the package currently doesn't install on Python versions 3.6 or newer due to the distribute install dependency. For example, see below for a screenshot showing a failed install on Python 3.6.5:

Screenshot showing install failure on Python 3.6

This pull request removes the distribute dependency when installing on Python >= 3.6 which makes the package install cleanly.

Resolves #17

@c-w c-w referenced this pull request May 18, 2019

Closed

Error when installing with pip #17

@ryan-roemer

This comment has been minimized.

Copy link
Owner

commented May 18, 2019

Fantastic work on this and the other PRs you've opened! I'll get everything reviewed, merged, and released next week when I have a moment to get my head back into this lib + Python again 😄

@c-w

This comment has been minimized.

Copy link
Collaborator Author

commented May 18, 2019

Thanks and looking forward to your reviews!

@ryan-roemer

This comment has been minimized.

Copy link
Owner

commented May 21, 2019

@c-w -- I've been digging into this, but I confess that I'm having difficulties getting back into this project with a modern python. Here's my current env:

$ python --version
Python 3.7.2
$ cat requirements_dev.txt 
Django>=1.8.0
Fabric3==1.14.post1
boto==2.48.0
pylint==2.3.1
python-swiftclient==3.5.0
Sphinx==1.6.1
sphinx-bootstrap-theme>=0.7.1

I'm attempting to run:

# Check lint, which fails presumably for a lot of modern stuff...
$ fab check

# Localdev server, serving up a local well-known directory on a unix-like system
$ fab run_server

... and fab run_server is failing for me.

Is there any chance that I can ask for a huge lift on your part to get fab run_server running for the demo project so I can jump in and kick the tires again on the project? (I really do apologize that I'm a couple years out of my last python professional work, so need a bit of help, and figure it would be great to get the project in shape to run in a deterministic, reproducible dev scenario again 😉 )

Thanks!

@ryan-roemer

This comment has been minimized.

Copy link
Owner

commented May 21, 2019

@c-w -- would you mind emailing me at ryan.roemer@formidable.com so I can touch base with a few other details to hopefully help make things easier wrt your needs and goals for work on this project? Or twitter DM too works if that's your jam: https://twitter.com/ryan_roemer

@c-w

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

@ryan-roemer as of 2095277 both fab check and fab run_server should work again out of the box (tested on Windows 10 with Python 3.7.3).

@ryan-roemer

This comment has been minimized.

Copy link
Owner

commented May 21, 2019

@c-w -- Looking great! 🎉 One last thing is when I run fab run_server and navigate to http://127.0.0.1:8000/admin/ I get 404s for:

... etc. If you happen to know how that works now, do you have any ideas for that?

@c-w

This comment has been minimized.

Copy link
Collaborator Author

commented May 22, 2019

@ryan-roemer The static media serving for django-admin should be fixed as of d3e34cc (tested with Django==1.8).

@c-w c-w merged commit b67b56a into ryan-roemer:master May 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:fix-install-py36 branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.