Fix exception translation#19
Merged
c-w merged 1 commit intoryan-roemer:masterfrom May 23, 2019
CatalystCode:fix-exception-translation
Merged
Fix exception translation#19c-w merged 1 commit intoryan-roemer:masterfrom CatalystCode:fix-exception-translation
c-w merged 1 commit intoryan-roemer:masterfrom
CatalystCode:fix-exception-translation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen behavior where the second or third initialization of the exception translation wrapper doesn't correctly dereference the
lazy_translationsin__new__which leads to some exceptions not being translated and therefore HTTP 500 errors coming through to the user.This pull request makes the wrapper more reliable by removing the need for
__new__and simplifying the code to dereference thelazy_translationsonly at usage time.