Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception translation #19

Merged
merged 1 commit into from May 23, 2019

Conversation

Projects
None yet
1 participant
@c-w
Copy link
Collaborator

commented May 18, 2019

I've seen behavior where the second or third initialization of the exception translation wrapper doesn't correctly dereference the lazy_translations in __new__ which leads to some exceptions not being translated and therefore HTTP 500 errors coming through to the user.

This pull request makes the wrapper more reliable by removing the need for __new__ and simplifying the code to dereference the lazy_translations only at usage time.

@c-w c-w merged commit fa6fea5 into ryan-roemer:master May 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:fix-exception-translation branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.