Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filesystem backend on Windows #31

Merged
merged 1 commit into from Jun 11, 2019
Merged

Fix filesystem backend on Windows #31

merged 1 commit into from Jun 11, 2019

Conversation

c-w
Copy link
Collaborator

@c-w c-w commented Jun 11, 2019

Currently there are some issues with the filesystem backend on Windows due to the difference between SEP = "/" used as a URL separator and a path separator which leads to non-top-level folders and files not being addressable as shown in the screenshots below.

Screenshot showing bad object name for file

Screenshot showing bad object name for directory

This pull request fixes the issues by ensuring that the app-side always sees paths separated by SEP and the OS always sees paths separated by the platform's path separator.

Copy link
Owner

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@c-w c-w merged commit a1b23e2 into master Jun 11, 2019
@c-w c-w deleted the fix-fs-windows branch June 11, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants