Skip to content

Fix filesystem backend on Windows#31

Merged
c-w merged 1 commit intomasterfrom
fix-fs-windows
Jun 11, 2019
Merged

Fix filesystem backend on Windows#31
c-w merged 1 commit intomasterfrom
fix-fs-windows

Conversation

@c-w
Copy link
Copy Markdown
Collaborator

@c-w c-w commented Jun 11, 2019

Currently there are some issues with the filesystem backend on Windows due to the difference between SEP = "/" used as a URL separator and a path separator which leads to non-top-level folders and files not being addressable as shown in the screenshots below.

Screenshot showing bad object name for file

Screenshot showing bad object name for directory

This pull request fixes the issues by ensuring that the app-side always sees paths separated by SEP and the OS always sees paths separated by the platform's path separator.

@c-w c-w force-pushed the fix-fs-windows branch from deb590a to e92fa9e Compare June 11, 2019 03:08
@c-w c-w force-pushed the fix-fs-windows branch from e92fa9e to b6cd641 Compare June 11, 2019 03:08
Copy link
Copy Markdown
Owner

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@c-w c-w merged commit a1b23e2 into master Jun 11, 2019
@c-w c-w deleted the fix-fs-windows branch June 11, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants