Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of doc paths with URL characters #41

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Fix rendering of doc paths with URL characters #41

merged 1 commit into from
Dec 10, 2019

Conversation

c-w
Copy link
Collaborator

@c-w c-w commented Dec 10, 2019 •
edited
Loading

Screenshot showing rendering of document with non-URL-safe character

Fixes #40

@c-w c-w mentioned this pull request Dec 10, 2019
Closed
ryan-roemer
ryan-roemer approved these changes Dec 10, 2019
View reviewed changes
Copy link
Owner

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-w c-w merged commit e7ff18d into master Dec 10, 2019
@c-w c-w deleted the fix-document-rendering branch December 10, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-roemer ryan-roemer ryan-roemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 objects with white spaces are not supported
2 participants
@c-w @ryan-roemer