Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fix bug in z-score calculation. Credit to Ivan.

  • Loading branch information...
commit 25b5de3f40a2167b41b22d468eb7e4a184ce9e7d 1 parent cbd602a
Patrick McKenzie authored March 16, 2010
4  README
... ...
@@ -1,4 +1,4 @@
1  
-A/Bingo Version 1.0.0
  1
+A/Bingo Version 1.0.1
2 2
 ======
3 3
 
4 4
 Rails A/B testing.  One minute to install.  One line to set up a new A/B test.
@@ -106,4 +106,4 @@ A/Bingo defaults to using the same cache store as Rails.  If you want to change
106 106
 Abingo.cache = ActiveSupport::Cache::MemCacheStore.new("cache.example.com:12345") #best if really memcacheDB
107 107
 
108 108
 
109  
-Copyright (c) 2009-2010 Patrick McKenzie, released under the MIT license
  109
+Copyright (c) 2009-2010 Patrick McKenzie, released under the MIT license
4  lib/abingo/statistics.rb
@@ -26,7 +26,7 @@ def zscore
26 26
 
27 27
     numerator = cr1 - cr2
28 28
     frac1 = cr1 * (1 - cr1) / n1
29  
-    frac2 = cr2 * (1 - cr1) / n2
  29
+    frac2 = cr2 * (1 - cr2) / n2
30 30
 
31 31
     numerator / ((frac1 + frac2) ** 0.5)
32 32
   end
@@ -87,4 +87,4 @@ def describe_result_in_words
87 87
     words
88 88
   end
89 89
 
90  
-end
  90
+end

0 notes on commit 25b5de3

Please sign in to comment.
Something went wrong with that request. Please try again.