Skip to content
Browse files

Fixed bug where conditions on an optionally associated object would t…

…hrow exceptions if the associated object was not present at the rule match time.
  • Loading branch information...
1 parent 7bcfd3d commit 6aaab9e440848b05ccc457c2260f1597c37bc35b @thatothermitch thatothermitch committed Apr 1, 2011
Showing with 8 additions and 1 deletion.
  1. +1 −1 lib/cancan/rule.rb
  2. +7 −0 spec/cancan/ability_spec.rb
View
2 lib/cancan/rule.rb
@@ -109,7 +109,7 @@ def matches_conditions_hash?(subject, conditions = @conditions)
if attribute.kind_of? Array
attribute.any? { |element| matches_conditions_hash? element, value }
else
- matches_conditions_hash? attribute, value
+ !attribute.nil? && matches_conditions_hash?(attribute, value)
end
elsif value.kind_of?(Array) || value.kind_of?(Range)
value.include? attribute
View
7 spec/cancan/ability_spec.rb
@@ -249,6 +249,13 @@
@ability.can?(:read, 1..5).should be_true
@ability.can?(:read, 4..6).should be_false
end
+
+ it "should not match subjects return nil for methods that must match nested a nested conditions hash" do
+ mock(object_with_foo = Object.new).foo { :bar }
+ @ability.can :read, Array, :first => { :foo => :bar }
+ @ability.can?(:read, [object_with_foo]).should be_true
+ @ability.can?(:read, []).should be_false
+ end
it "should not stop at cannot definition when comparing class" do
@ability.can :read, Range

0 comments on commit 6aaab9e

Please sign in to comment.
Something went wrong with that request. Please try again.