Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

CanCan status? #819

Closed
runemadsen opened this Issue · 5 comments

3 participants

@runemadsen

Hi @ryanb

I'm wondering what the status of cancan development is these days. I can see hundreds of issues, and 33 unmerged pull requests. I know we're quite a few people using this gem in production, so I'm wondering if there's anything specific you need help with?

Personally there are 3 big bugs in cancan right now preventing me from doing more with it, but I don't know how to contribute if the pull requests aren't looked at. I added a failing spec for one of them (runemadsen@98446bb) and I would love to fix it, but I want to make sure the fixes are accepted.

Anyway, let me know if there's anything I can do. I know the faq says not to post questions here, but I doubt I'll get a response on Stackoverflow.

  • Rune
@natebird

I'm trying to help Ryan cut through all of the issues and pull requests so he can focus on seeing just what needs to be merged in immediately. If you can help 'triage' the issue tracker and select the top 5 pull requests for him to look at I think we can get things moving on this project again.

@runemadsen

Ok, great. I'd love to help. I think the biggest issues (at least for me right now) are these two.

#781 and duplicate: #646
CanCan just doesn't work with nested condition join in Rails 3
This seems to be the pull request that solves it: #806

#788
With multiple associations in conditions, CanCan will OR instead of AND. As you can see in the issue, I added a failing spec in my fork.
I don't see a pull request for this, so let me know if you want me to take a stab at it.

I can spend more time looking through them all. Let me know how you would like to proceed.

@natebird

@runemadsen Thanks for the quick response. I agree that the nested condition join in Rails 3 is one of the biggest issues.

If you can create a pull request using your failing spec for #788 that would be awesome.

I'm going to try and go through the pull requests and categorize them because it looks like a lot of them are very similar or are solving similar problems.

@runemadsen

Ok, great. I'll see if I can fix #788.

@totallymike

I suggest this issue be closed. Helping to triage is fantastic, but in the very same spirit, this is still an open issue...

@runemadsen runemadsen closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.