Port fix for namespaced params from 2.0 back to 1.6 #554

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

cgunther commented Jan 31, 2012

This is a port of the fix for #349, but back ported to the 1.6 series. Commit: c94de4a

Probably also solves #541, #528, and #524.

@Sija Sija pushed a commit to Sija/cancan that referenced this pull request Mar 19, 2012

Sijawusz Pur Rahnama Merged PR #554 5621c5e
Collaborator

jeremyf commented May 10, 2012

[Verified] Tests pass. I like removing references to instance_variables in preference for method calls.

Owner

ryanb commented May 11, 2012

I like this patch but it looks like it no longer merges cleanly. If someone wants to fix I will get this pulled in.

Collaborator

derekprior commented May 14, 2012

I've rebased on master and ensured all specs pass. See the referenced pull above. Recommend closing this.

Collaborator

jeremyf commented May 14, 2012

Closing this pull request as it is superseded by #619.

jeremyf closed this May 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment