Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support Mass-Assignment Role of ActiveRecord #577

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
8 participants

jpascal commented Mar 8, 2012

No description provided.

Sija pushed a commit to Sija/cancan that referenced this pull request Mar 19, 2012

ramaboo commented Apr 9, 2012

I ran into this problem as well.. now that attr_accessible takes an :as option it seems like this is an important fix. Any chance of getting it rolled up into the gem?

+1 for adding this!

pietia commented Apr 30, 2012

+2

driehle commented May 7, 2012

+1 would like to see this in cancan!

Collaborator

jeremyf commented May 10, 2012

@ramaboo I ran the tests and they do not pass on master branch. I'd imagine with a month passing there may be an API change.

Also please remove the white space at the end of # Passing to ActiveRecord for support Mass-Assignment Role in lib/cancan/controller_additions.rb

Hit me up when you get this working.

Collaborator

andhapp commented Jun 18, 2012

Can someone write specs around this behaviour? It won't be merged into master without specs. Thanks.

Written some specs for this in #657

Collaborator

andhapp commented Jun 22, 2012

Hello all, I am closing this pull request as @rvanlieshout has updated the pull request with some specs. Let's carry on a discussion there (#657).

@andhapp andhapp closed this Jun 22, 2012

ghost pushed a commit to bignerdranch/cancan that referenced this pull request Apr 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment