Adapter for MongoMapper #649

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants

Based on Mongoid adapter. Can you guys review it, please? I'm using it in my projects and seems like it's pretty sufficient for my needs.

Collaborator

mikepack commented Jun 18, 2012

Merges cleanly and specs pass.

What about merging it?

Collaborator

mikepack commented Jun 19, 2012

That's up to @ryanb.

+1 for merging

Collaborator

andhapp commented Jun 30, 2012

@Juggler: Thanks. Unfortunately, the 1.x branch (current master) is only for bug fixes. Can you please close this pull request and create another pull request for the 2.0 branch? Thanks.

***DANGER, huge issue!
Plucky::Query.remove() actually calls collection.remove()
This will remove all the records matching rule.conditions from the database - which is not intended, I guess ... ;)

Owner

maxprokopiev replied Sep 17, 2013

oops, I'll check this

Me too. Expect a pull request today.
Also thanks for all the specs! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment