spec & fix for params[:controller] in underscore format #681
Conversation
|
Exactly! But code in cancan @params[:controller].split("::")[0..-2]splits it by :: as if it was MyEngine::ProjectsController looks like there's also unnecessary .gsub('Controller', '') in such case. |
| @params.merge!(:controller => "my_engine/projects_controller", :action => "show", :id => project.id) | ||
| resource = CanCan::ControllerResource.new(@controller) | ||
| resource.load_resource | ||
| @controller.instance_variable_get(:@project).should == project |
There was a problem hiding this comment.
IIRC, @ryanb prefers to use .should eq instead of .should ==
|
I've rebased against ryanb / cancan and changed == to eq :) |
|
Dear submitter, Since cancan/raynB hasn't been active for more than 6 months and no body else then ryam himself has commit permissions the cancan project is on a stand still. If your feel that your pull request or bug is still applicable (and hasn't been merged in to cancan) it would be really appreciated if you would resubmit it to cancancan (https://github.com/cancancommunity/cancancan) We hope to see you on the other side! |
|
Closed, as it's fixed differently in cancancan |
code supposed that @params[:controller] is in camel case, but actually in rails it's in snake case
so i added .camelize in some methods