Replace meta_where with squeel, fix pending rspec tests. #711

Open
wants to merge 1 commit into from

4 participants

@fillman

This is not finish. A lot of new features will come up using squeel. But at least it should work for most users having old styled meta_where conditions.

@andhapp
Collaborator

@filip Nice work.

AFAIK, with 2.0, plans are to rewrite the entire meta_where related code and make it more extendable for the future. I will run this past @ryanb and get his thoughts on it.

@fillman

Sure, maybe there's somewhere a todo list or plans list for 2.0 branch so I can read what is needed and help you guys?

@the8472

pending "does ActiveRecord no longer support a deep nested hash of conditions?"

This would only work with squeel. Not when combining cancan with vanilla active record.

Not that this would really change anything as this feature is currently broken anyway with newer rails versions.

@ogerman ogerman added a commit to ogerman/cancan that referenced this pull request Jul 26, 2013
@fillman fillman merge pull #711 by fillman (Replace meta_where with squeel, fix pendi…
…ng rspec tests)
423ae86
@xhoy

Dear submitter, Since cancan/raynB hasn't been active for more than 6 months and no body else then ryam himself has commit permissions the cancan project is on a stand still.
Since cancan has several issues including missing support for rails 4 cancan is moving forward to cancancan. More details on: #994

If your feel that your pull request or bug is still applicable (and hasn't been merged in to cancan) it would be really appreciated if you would resubmit it to cancancan (https://github.com/cancancommunity/cancancan)

We hope to see you on the other side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment