Avoid unnecessary recalculation of expanded_actions #875

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@outoftime

No description provided.

Don't unnecessarily recalcuate expanded ability
Simple optimization to remove unnecessary calculation of a rule's expanded
ability, which appeared as a bottleneck in performance analysis of our
application.
@outoftime

This comment has been minimized.

Show comment Hide comment
@outoftime

outoftime May 31, 2013

Owner

Oops, the commit name/message says ability when I meant actions.

Owner

outoftime commented on 99817da May 31, 2013

Oops, the commit name/message says ability when I meant actions.

expanded_actions reader
Oops, forgot to commit this
@xhoy

This comment has been minimized.

Show comment Hide comment
@xhoy

xhoy Jul 1, 2014

Thanks for your submission! The ryanb/cancan repository has been inactive since Sep 06, 2013.
Since only Ryan himself has commit permissions, the CanCan project is on a standstill.

CanCan has many open issues, including missing support for Rails 4. To keep CanCan alive, an active fork exists at cancancommunity/cancancan. The new gem is cancancan. More info is available at #994.

If your pull request or issue is still applicable, it would be really appreciated if you resubmit it to CanCanCan.

We hope to see you on the other side!

xhoy commented Jul 1, 2014

Thanks for your submission! The ryanb/cancan repository has been inactive since Sep 06, 2013.
Since only Ryan himself has commit permissions, the CanCan project is on a standstill.

CanCan has many open issues, including missing support for Rails 4. To keep CanCan alive, an active fork exists at cancancommunity/cancancan. The new gem is cancancan. More info is available at #994.

If your pull request or issue is still applicable, it would be really appreciated if you resubmit it to CanCanCan.

We hope to see you on the other side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment