Clear up inconsistency in authorize_resource examples #924

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@kyletolle

Forward

While reading through the source code and its examples, I noticed what I believe is an inconsistency in the example code and example explanation for authorize_resource.

I created two comments on the related lines in the commit where this was introduced. The comments are asking whether my hunch is correct.

25a1c55#L2R115
25a1c55#L2R118

This pull request is created in case my hunch proves correct, and the documentation needs to be updated to reflect that.

Change Description

Changed the explanation of the code in the example to have the same references and order as the related example code.

Previously, the example code referenced a book, whereas the explanation of that example code mentioned a show. The example and the explanation did not match.

@kyletolle kyletolle Clear up inconsistency in authorize_resource examples
Changed the explanation of the code in the example to have the same references and order as the related example code.
693701c
@kyletolle kyletolle referenced this pull request Aug 21, 2013
@ryanb adding :through option to replace :nesting option and moving Resource…
…Authorization class code into ControllerResource
25a1c55
@xhoy

Thanks for your submission! The ryanb/cancan repository has been inactive since Sep 06, 2013.
Since only Ryan himself has commit permissions, the CanCan project is on a standstill.

CanCan has many open issues, including missing support for Rails 4. To keep CanCan alive, an active fork exists at cancancommunity/cancancan. The new gem is cancancan. More info is available at #994.

If your pull request or issue is still applicable, it would be really appreciated if you resubmit it to CanCanCan.

We hope to see you on the other side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment