Skip to content
This repository

Missing HTTPS and URI require #50

Closed
wants to merge 6 commits into from

4 participants

Clint Talbott Matt McDermott Nicholas Firth-McCoy Ryan Bates
Clint Talbott

There's already a pull request for the net/https require. Think the uri require is necessary in some cases as well for URI.parse to work correctly when using ssl. I was getting an EOFError (end of file error) until I added the net/https and uri requires.

Matt McDermott

+1

Nicholas Firth-McCoy

Hi @cctalbott, as of version 1.0.2, private_pub does require 'net/https'.

In addition, Net::HTTP itself will require 'uri', so requiring it explicitly in lib/private_pub.rb is unnecessary.

Cheers,
Nicholas

Ryan Bates ryanb closed this February 06, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
1  .gitignore
@@ -3,3 +3,4 @@
3 3
 *.gem
4 4
 Gemfile.lock
5 5
 .bundle
  6
+*~
2  lib/private_pub.rb
... ...
@@ -1,5 +1,7 @@
1 1
 require "digest/sha1"
2 2
 require "net/http"
  3
+require "net/https"
  4
+require 'uri'
3 5
 
4 6
 require "private_pub/faye_extension"
5 7
 require "private_pub/engine" if defined? Rails
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.