empty $data array() returned in wire/core/Modules.php prevents saving modules configuration

[Da-Fecto]

in 2.5.14 public static function getModuleConfigInputfields(array $data) get an empty array, but that shouldn't be that way.

Report here: https://processwire.com/talk/topic/7588-admin-custom-files/?p=84276
Maybe related: https://processwire.com/talk/topic/4865-custom-upload-names/page-4#entry84264

[Da-Fecto]

On this commit the 'bug' is introduced.

on this line the empty array is returned.

// changing this (line 1951 wire/core/Modules.php )
// if(!isset($this->configData[$id])) return array(); // module has no config data
// if(is_array($this->configData[$id])) return $this->configData[$id];

// to this solves the issue
if(is_array($this->configData[$id])) {
    if (count($this->configData[$id])) return $this->configData[$id];
    return array(); // module has no config data
}

[adrianbj]

Thanks for taking the time to track this down Martijn.

To avoid missing index notices, I modified slightly to:

if(isset($this->configData[$id]) && is_array($this->configData[$id])) {
    if (count($this->configData[$id])) return $this->configData[$id];
    return array(); // module has no config data
}

I can confirm this also fixes the issues with Custom Upload Names to you link to above.

[Da-Fecto]

The isset is a weird one Adrian (I think). $this->configData[$id] is just an array at this point, so the code reads to me like: isset(array()). Is that even possible ?

[adrianbj]

I have always used it, but that might not make it right :)

You could always use:

array_key_exists($id, $this->configData)

instead, but I don't see an issue with isset in this case. Here's an interesting read:
http://stackoverflow.com/questions/3210935/difference-between-isset-and-array-key-exists

[Da-Fecto]

Thanks for the info & glad it fixes the others issue.
(Don't know why I mentioned the isset thingy 👎 )

[Da-Fecto]

Patch fixed this issue as well.

[Da-Fecto]

Latest 2.5.14 seems to fix all instances I see/find.