New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented simple OR Selector for field dependencies #991

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
3 participants
@LostKobrakai
Copy link

LostKobrakai commented Mar 6, 2015

It's evaluating the | selectorpart but not advanced or-groups.

@owzim

This comment has been minimized.

Copy link

owzim commented Mar 6, 2015

👍

@LostKobrakai LostKobrakai deleted the LostKobrakai:patch-1 branch Mar 13, 2015

@LostKobrakai LostKobrakai restored the LostKobrakai:patch-1 branch Mar 13, 2015

@LostKobrakai LostKobrakai reopened this Mar 13, 2015

ryancramerdesign added a commit that referenced this pull request Mar 25, 2015

Add @LostKobrakai PR #991 which adds OR "|" support to field dependen…
…cy VALUES on the JS side. Previously it was only supported on the PHP side. Since we were adding that, I went ahead and added OR support for the FIELDS part of the dependency as well. That one was not previously supported in either the PHP or JS side, so support has been added in both.
@ryancramerdesign

This comment has been minimized.

Copy link
Owner

ryancramerdesign commented Mar 25, 2015

Thanks, good addition–I have added this. While in there, I went ahead and added OR support to the field part of the selectors as well so that you can do a|b=c in addition to a=b|c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment