Make multiple metrics on one line explicit. #29

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Collaborator

danp commented Mar 18, 2013

The multi-metric support added as part of #27 considered anything matching key=floatval on the same line as measure=foo to be a metric in the form foo.key with a value of floatval.

This PR changes that a bit to make things more explicit: things matching measure.key=floatval on the same line as measure=foo will be considered to be a metric in the form foo.key with a value of floatval.

My motivation is cutting down on measurements sent to librato for metrics that won't be useful which translates primarily to lower cost.

Owner

ryandotsmith commented Mar 25, 2013

@dpiddy One drawback to this approach is that it makes it nearly impossible to measure data from the Heroku router.

Collaborator

danp commented Mar 25, 2013

@ryandotsmith I guess it depends on how far the special case #27 introduced for the router should go. For example, it act as if all keys from the router were prefixed with measure..

Owner

ryandotsmith commented Mar 25, 2013

@dpiddy I wish cost wasn't a motivating factor here. I really don't like measure.* in the log line. It seems like noise. Still racking my brains on this one...

Owner

ryandotsmith commented Apr 2, 2013

@dpiddy thanks for the inspiration on this one. I pushed some bits around and brought over your ideas in #44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment