Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

ember build with Handlebars 1.0.0-rc.3 throws an error. #9

Closed
jergason opened this Issue · 2 comments

2 participants

@jergason

The Handlebars 1.0.0-rc.3 that I submitted in the pull request assigns itself to this.Handlebars, not window.Handlebars. This breaks inside of Handlebars, since this version looks for it on window.Handlebars.

I tried building handlebars from master, which fixes the first problem but breaks inside of Ember, since Ember expects Handlebars to be on window.Handlebars.

I was able to fix the problem by hacking handlebars.js line 26 from var Handlebars = {} to window.Handlebars = {}, but obviously this is the Devil.

@jergason

Here is a commit that monkey-patches handlebars.js and updates the package.json to work with the rc.3: jergason@243629f. I am a little gun-shy to pull-request it, since it is evil and my last pull request broke stuff. What think ye?

@ryanflorence

Closed by #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.