Use pcall in OnIconChanged for proper error handling #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor OnIconChanged function to use pcall for safer execution. Signed-off-by: epix <71335972+Epixerty@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the OnIconChanged function by replacing a task.wait() call with proper pcall error handling to prevent console errors when StarterGui:GetCore("TopbarEnabled") might not be available.
- Replaces
task.wait()withpcallto handle potential errors gracefully - Adds early return when the operation fails to prevent further execution with invalid state
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ryanlua
approved these changes
Oct 1, 2025
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
task.wait()this should be wrapped in a pcall to prevent filling the console with errors. It's not guaranteed to exist even after 1 frame.By the way, this current
task.wait()"fix" isn't implemented in the current wally release at least, I would appreciate if you could merge this PR or at least have another wally release since that's better than nothing