From a8b050900dc3e6bfe2243312a4eb9818e06958f8 Mon Sep 17 00:00:00 2001 From: epix <71335972+Epixerty@users.noreply.github.com> Date: Wed, 1 Oct 2025 09:51:31 +0200 Subject: [PATCH 1/3] Use pcall in OnIconChanged for error handling Refactor OnIconChanged function to use pcall for safer execution. Signed-off-by: epix <71335972+Epixerty@users.noreply.github.com> --- src/init.luau | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/init.luau b/src/init.luau index 0958487..d8af847 100644 --- a/src/init.luau +++ b/src/init.luau @@ -1481,8 +1481,12 @@ end local function OnIconChanged(enabled: boolean): () -- Check for enabling/disabling the whole thing - task.wait() - enabled = enabled and StarterGui:GetCore("TopbarEnabled") + local success, enabled = pcall(function() + return enabled and StarterGui:GetCore("TopbarEnabled") + end) + + if not success then return end + WholeThingEnabled = enabled MainFrame.Visible = enabled From 55a243df25ebb56b81f4ca042ab6db16226aafef Mon Sep 17 00:00:00 2001 From: Ryan Luu Date: Wed, 1 Oct 2025 01:05:28 -0700 Subject: [PATCH 2/3] Fix shadowing Signed-off-by: Ryan Luu --- src/init.luau | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/init.luau b/src/init.luau index d8af847..e87edd7 100644 --- a/src/init.luau +++ b/src/init.luau @@ -1481,11 +1481,13 @@ end local function OnIconChanged(enabled: boolean): () -- Check for enabling/disabling the whole thing - local success, enabled = pcall(function() + local success, topbarEnabled = pcall(function() return enabled and StarterGui:GetCore("TopbarEnabled") end) - - if not success then return end + + if not success then + return + end WholeThingEnabled = enabled MainFrame.Visible = enabled From f2fe93bc1aa3373cd7446a34ca940cb5aa327857 Mon Sep 17 00:00:00 2001 From: Ryan Luu Date: Wed, 1 Oct 2025 01:07:18 -0700 Subject: [PATCH 3/3] Fix linting Signed-off-by: Ryan Luu --- src/init.luau | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/init.luau b/src/init.luau index e87edd7..8127e2b 100644 --- a/src/init.luau +++ b/src/init.luau @@ -1481,14 +1481,14 @@ end local function OnIconChanged(enabled: boolean): () -- Check for enabling/disabling the whole thing - local success, topbarEnabled = pcall(function() + local success, _topbarEnabled = pcall(function() return enabled and StarterGui:GetCore("TopbarEnabled") end) if not success then return end - + WholeThingEnabled = enabled MainFrame.Visible = enabled