Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 2 #7

Closed
ryanmasondavies opened this issue Mar 22, 2016 · 2 comments
Closed

Update to Swift 2 #7

ryanmasondavies opened this issue Mar 22, 2016 · 2 comments

Comments

@ryanmasondavies
Copy link
Owner

Have gone through the basic migration process to support Swift 2, but haven't fully embraced the improvements. Code should be refactored to use newer syntax such as guard, defer, where needed, and use struct and protocols in place of classes where possible.

@digitallysavvy
Copy link

I just tried your current build on an iPhone 6 using iOS 9.3 and the entire camera image is pixilated, not just the face. I created a new pull request with updated code to work with Swift 2.3. It uses the black circle over the face.
img_2921
img_2916

@ryanmasondavies
Copy link
Owner Author

Thanks! I've replied to your pull request. It looks like you haven't got the latest changes in the repo – if you can pull and merge the master branch with your pull request, I'd be happy to accept it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants