Skip to content

Requests image posting #91

Merged
merged 7 commits into from Jun 24, 2012

2 participants

@michaelhelmick
Collaborator
  • README.rst, kind of tried to clean up docs with more examples
  • No longer need oauth2 lib 👍
  • Removal of oauth2 lib, requests has fully taken over. :)
  • FIXED: Obtaining auth url with specified callback was broke.. wouldn't give you auth url if you specified a callback url
  • Updated requests to pass the headers that are passed in the init, so User-Agent is once again Twython Python Twitter Library v2.1.0 👍 :)
  • Catching exception when Stream API doesn't return valid JSON to parse
  • Removed DELETE method. As of the Spring 2012 clean up, Twitter no longer supports this method
  • Updated post internal func to take files as kwarg
  • params - params or {} only needs to be done in _request, just a lot of redundant code on my part, sorry ;P
  • Removed bulkUserLookup, there is no need for this to be a special case, anyone can pass a string of username or user ids and chances are if they're reading the docs and using this library they'll understand how to use lookupUser() in twitter_endpoints.py passing params provided in the Twitter docs
  • Changed internal oauth_secret variable to be more consistent with the keyword arg in the init oauth_token_secret
  • README.md vs README.markdown just look cleaner
  • Updating documentation to look clean, imo. :P
  • Set self.auth = None so that calls (like searching or getting a profile avatar don't error out) Fixes #90
michaelhelmick added some commits May 16, 2012
@michaelhelmick michaelhelmick 2.1.0 release
* README.rst, kind of tried to clean up docs with more examples
* No longer need oauth2 lib 👍
f2cd0d5
@michaelhelmick michaelhelmick 2.1.0 Release
* Removal of oauth2 lib, `requests` has fully taken over. :)
* FIXED: Obtaining auth url with specified callback was broke..
wouldn't give you auth url if you specified a callback url
* Updated requests to pass the headers that are passed in the init, so
User-Agent is once again `Twython Python Twitter Library v2.1.0`
👍 :)
* Catching exception when Stream API doesn't return valid JSON to parse
* Removed `DELETE` method. As of the Spring 2012 clean up, Twitter no
longer supports this method
* Updated `post` internal func to take files as kwarg
* `params - params or {}` only needs to be done in `_request`, just a
lot of redundant code on my part, sorry ;P
* Removed `bulkUserLookup`, there is no need for this to be a special
case, anyone can pass a string of username or user ids and chances are
if they're reading the docs and using this library they'll understand
how to use `lookupUser()` in `twitter_endpoints.py` passing params
provided in the Twitter docs
* Changed internal `oauth_secret` variable to be more consistent with
the keyword arg in the init `oauth_token_secret`
5e81719
@michaelhelmick michaelhelmick 2.1.0 Release
* .md just look cleaner
* Updating documentation to look clean, imo. :P
32a83a6
@michaelhelmick michaelhelmick 2.1.0 Release
Set `self.auth` = None so that calls (like searching or getting a
profile avatar don't error out) Fixes 90
d93b48c
@michaelhelmick
Collaborator

We need to wait for a new release (0.12.2 I believe it will be) of requests before we can merge this in

@ryanmcgrath
Owner

Hey,

Waiting for new release is fine; in the meantime, that auth fix is biting some people in the ass. Separate pull request?

@michaelhelmick
Collaborator
@michaelhelmick
Collaborator

@ryanmcgrath Hey, this should be all go to go :)

@michaelhelmick
Collaborator

You can close #80 and #90 with this merge too.

@ryanmcgrath ryanmcgrath pushed a commit that referenced this pull request Jun 24, 2012
Ryan McGrath Merge branch 'requests_image_posting' (Pull Request #91)
- Fixes for README
- Re-added a bulkUserLookup method that warns for deprecation
- Merged in @michaelhelmick's work on media and oauth2 deprecation

Conflicts:
	setup.py
	twython/twython.py
068c504
@ryanmcgrath ryanmcgrath merged commit f232b87 into ryanmcgrath:master Jun 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.