Skip to content

Line reader doesn't close open files, results in "too many open files" error. #32

Closed
jarod2d opened this Issue Jul 7, 2012 · 2 comments

2 participants

@jarod2d
jarod2d commented Jul 7, 2012

Line readers open files but don't ever close them. If you create enough line readers you'll get the error EMFILE, too many open files. The files need to be closed to avoid this.

There isn't really a way for the line reader to close the file automatically because it doesn't know when the user is done with it, so the user will need to close the file themselves. Currently they can do so by doing something like fs.closeSync(reader.fd), but this isn't documented -- they'll need to look at the source to know that they can grab the file descriptor from the reader.

This should be documented in the readme, and perhaps a function should be added to the line reader that performs the close for you.

@ryanmcgrath ryanmcgrath pushed a commit that referenced this issue Nov 9, 2012
Ryan McGrath Fixes issue #32 676e210
@ryanmcgrath
Owner

Done. 4 months late, but done.

@ryanmcgrath ryanmcgrath closed this Nov 9, 2012
@jarod2d
jarod2d commented Nov 9, 2012

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.