Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update lib/wrench.js #44

Closed
wants to merge 1 commit into from

2 participants

@victorjonsson

Code crashes on this line if opts is undefined. I'm guessing that
the default behavior should be that symlinked files gets copied as
new files unless the option inflateSymlinks is set to false.

@victorjonsson victorjonsson Update lib/wrench.js
Code crashes on this line if opts is undefined. I'm guessing that 
the default behavior should be that symlinked files gets copied as
new files unless the option inflateSymlinks is set to false.
061c2e0
@ryanmcgrath ryanmcgrath referenced this pull request from a commit
@ryanmcgrath Patch for pull request #44 d396853
@ryanmcgrath
Owner

Merged in something to hit this - the pull request couldn't be automatically merged. Let me know if issues? Thanks for pointing it out!

@ryanmcgrath ryanmcgrath closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 19, 2012
  1. @victorjonsson

    Update lib/wrench.js

    victorjonsson authored
    Code crashes on this line if opts is undefined. I'm guessing that 
    the default behavior should be that symlinked files gets copied as
    new files unless the option inflateSymlinks is set to false.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/wrench.js
View
2  lib/wrench.js
@@ -205,7 +205,7 @@ exports.copyDirSyncRecursive = function(sourceDir, newDirLocation, opts) {
} else if(currFile.isSymbolicLink()) {
var symlinkFull = fs.readlinkSync(sourceDir + "/" + files[i]);
- if (!opts.inflateSymlinks) {
+ if (opts !== undefined && opts.inflateSymlinks === false) {
fs.symlinkSync(symlinkFull, newDirLocation + "/" + files[i]);
continue;
}
Something went wrong with that request. Please try again.