New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better way to setup the config.js file #1

Closed
ryanseddon opened this Issue Jun 3, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@ryanseddon
Owner

ryanseddon commented Jun 3, 2012

Setting up the config.js file is silly it should be a command option to run you through the options perhaps? Can anyone suggest an approach or help?

@webxl

This comment has been minimized.

Show comment
Hide comment
@webxl

webxl Jun 5, 2012

I like having a config file, but it shouldn't be required to edit the one in the lib directory. Either or both of these would definitely help:

  1. add a " -c path_to_config" option to bunyip.
  2. add additional default locations for the config, like a dotfile (~/.bunyip) and ./config.js (working directory)

Perhaps you can use commander to walk through the options and generate ~/.bunyip

webxl commented Jun 5, 2012

I like having a config file, but it shouldn't be required to edit the one in the lib directory. Either or both of these would definitely help:

  1. add a " -c path_to_config" option to bunyip.
  2. add additional default locations for the config, like a dotfile (~/.bunyip) and ./config.js (working directory)

Perhaps you can use commander to walk through the options and generate ~/.bunyip

@ryanseddon

This comment has been minimized.

Show comment
Hide comment
@ryanseddon

ryanseddon Jun 6, 2012

Owner

Yeah that might be a good option. I'll want it to work on windows too so I'll investigate doing a commander walk through and the ability to specify your own default location for config.js.

Owner

ryanseddon commented Jun 6, 2012

Yeah that might be a good option. I'll want it to work on windows too so I'll investigate doing a commander walk through and the ability to specify your own default location for config.js.

@jayarjo

This comment has been minimized.

Show comment
Hide comment
@jayarjo

jayarjo Jun 25, 2012

I did add support for this on my fork, but then I went on with rewriting things here and there (couldn't resist to make it "more consistent"... ), so now I guess it can't be pulled in :|

jayarjo commented Jun 25, 2012

I did add support for this on my fork, but then I went on with rewriting things here and there (couldn't resist to make it "more consistent"... ), so now I guess it can't be pulled in :|

@ryanseddon

This comment has been minimized.

Show comment
Hide comment
@ryanseddon

ryanseddon Jun 26, 2012

Owner

Perhaps you could create a branch and just do the config option changes in your fork? I'd happy to pull that in.

I'm liking some of the other stuff you've done too. The hub option is pretty much exactly as I have done it on my local copy and adds the feature I mention in issue #4.

Owner

ryanseddon commented Jun 26, 2012

Perhaps you could create a branch and just do the config option changes in your fork? I'd happy to pull that in.

I'm liking some of the other stuff you've done too. The hub option is pretty much exactly as I have done it on my local copy and adds the feature I mention in issue #4.

ryanseddon added a commit that referenced this issue Aug 20, 2012

Merge branch 'master' of https://github.com/ryanseddon/bunyip into gh…
…-pages

* 'master' of https://github.com/ryanseddon/bunyip:
  Bumped version and added documentation
  Added config check for localbrowsers so you don't need one to run them
  Experimenting with launching locally installed browsers
  Added release history info
  Added config generator command, config flag - Added config command e.g. `bunyip config config.js` fixes #1 - Added -c flag to specify path to a config file, defaults to cwd - Re-architectured helpers.js to browserstack.js - Fixed undefined value when killing browserstack workers - Bumped version to 0.1.3
  Bumped required node version, fixes #7, and added .editorconfig file
  Bumped required node version and added .editorconfig file
  Yeti 0.2.6 release has breaking changes force 0.2.5
  Update lib/helpers.js: Remove duplication.
  Remove switch statement and simplify the platform helper keywords
  Fix markdown link in readme
  Added keywords to package.json
  Bunyip initial release version 0.1.0 - Broke lib into manageable chunks - Added grunt.js - Did very simple unit testing using cli-easy - Some detailed instructions in the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment