Ryan Seddon ryanseddon

Organizations

Modernizr
ryanseddon commented on pull request Modernizr/Modernizr#1548
Ryan Seddon

dosen\'t -> doesn\'t typo in both.

ryanseddon commented on pull request Modernizr/Modernizr#1548
Ryan Seddon

don't need to the space here

ryanseddon commented on pull request Modernizr/Modernizr#1548
Ryan Seddon

Love your work :+1:

Ryan Seddon
Push fx fix into v3 builder
1 commit with 3 additions and 3 deletions
ryanseddon deleted branch fix-builder at Modernizr/v3.modernizr.com
Ryan Seddon
Ryan Seddon
Fix builder bug, css classes, dev size, dev build
1 commit with 9 additions and 8 deletions
ryanseddon commented on pull request Modernizr/v3.modernizr.com#8
Ryan Seddon

I know right, this will scare people into thinking about custom builds rather than a riduclous catch all.

ryanseddon commented on pull request Modernizr/v3.modernizr.com#8
Ryan Seddon

@Modernizr/team-modernizr can someone do a quick once over

Ryan Seddon
Fix builder bug, css classes, dev size, dev build
1 commit with 9 additions and 8 deletions
ryanseddon commented on pull request Modernizr/modernizr.com#53
Ryan Seddon

Fixed here 867cbfc

Ryan Seddon
  • Ryan Seddon 867cbfc
    Link banner to download page on v3
ryanseddon commented on pull request Modernizr/modernizr.com#53
Ryan Seddon

yep realised that too, fixing now

ryanseddon deleted branch add-beta-flag at Modernizr/modernizr.com
Ryan Seddon
Ryan Seddon
Add beta flag to main site.
1 commit with 1,778 additions and 3 deletions
ryanseddon commented on pull request Modernizr/modernizr.com#53
Ryan Seddon

Happy with it saying beta even though we have alpha cuts?

ryanseddon commented on pull request Modernizr/modernizr.com#53
Ryan Seddon

Probably hard to tell but I copied @stucox styles he did on the banner for v3 site Modernizr/v3.modernizr.com@b7f0dba#diff-361ef4eb9c8a7b86b8df3dc7…

Ryan Seddon
Add beta flag to main site.
1 commit with 1,778 additions and 3 deletions
ryanseddon commented on pull request Modernizr/Modernizr#1533
Ryan Seddon

Thanks @rrrene look forward to landing this, great addition to the project.

ryanseddon commented on pull request Modernizr/Modernizr#1537
Ryan Seddon

Can't think of a better name approximateEquals, that's probably worse. I'm happy to combine the two tests, can inject 4 elements and just extend t…

ryanseddon commented on pull request Modernizr/Modernizr#1545
Ryan Seddon

LGTM :+1:

Ryan Seddon

Closing this issue.

Ryan Seddon
Script elements are not evaluated
ryanseddon commented on pull request Modernizr/Modernizr#1533
Ryan Seddon

yeah would much prefer configuration to be in package.json under some key, much like browserify uses the browser key to store config.

ryanseddon commented on pull request Modernizr/Modernizr#1533
Ryan Seddon

@rrrene the status page doesn't seem to parse any of the files in the feature-detects folder?

ryanseddon commented on pull request Modernizr/Modernizr#1533
Ryan Seddon

@patrickkettner thoughts? I think this is great.