Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input checks #27

Merged
merged 5 commits into from Jul 9, 2019

Conversation

@FireLemons
Copy link
Contributor

commented Jul 8, 2019

Added input checks to see if date arguments are date objects and that those date objects are valid.
Changed the phase range function to output even if the end date is before the start date.

@ryanseys

This comment has been minimized.

Copy link
Owner

commented Jul 8, 2019

Thanks for the PR. Please run "standard --fix" to fix the linting issues and update your PR.

lib/lune.js Outdated Show resolved Hide resolved
lib/lune.js Show resolved Hide resolved
@ironwallaby

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

One further pretty nitpicky comment from me, but otherwise I think this looks good and is helpful! :)

Copy link
Collaborator

left a comment

:shipit:

@ryanseys ryanseys merged commit f0498f0 into ryanseys:master Jul 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.