New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
irssi: add module #552
irssi: add module #552
Conversation
irssi is a cli IRC client.
cool though I would have preferred to see a weechat one xD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Looks good in general, I've just added a few comments.
This commit integrates the changes recommended in nix-community#552
This commit integrates the changes recommended in nix-community#552
b640d90
to
373e705
Compare
Thanks! I've squashed and rebased into master in 02a5a67. I made a few slight alterations of minor things I noticed when doing the merge, like removing the unnecessary |
I wanted to switch to a CLI-based IRC client. As I did not see anyone available as a module, I decided to write one.
I plan to make more options configurable, so it might make sense to wait with the merge.
So far, this module allows basic configuration of the chatnets, servers and channels. As an example config:
As far as I understood, irssi allows the usage of plugins to add other network types (i.e. XMPP). So far,
chatnets.<name?>.type
is not checked for validity.Note that this is my first pull request, so I'd love some feedback :) I hope that I understood the syntax guidelines correctly.