Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irssi: add module #552

Closed
wants to merge 3 commits into from
Closed

Conversation

CRTified
Copy link
Contributor

I wanted to switch to a CLI-based IRC client. As I did not see anyone available as a module, I decided to write one.
I plan to make more options configurable, so it might make sense to wait with the merge.
So far, this module allows basic configuration of the chatnets, servers and channels. As an example config:

    programs.irssi = {
       enable = true;
       aliases = {J = "join"; BYE = "quit"; };
       chatnets = {
         freenode = {
           type = "IRC";
           nick = "FOO";
           autoCmd = [ ];
           channels = [
             { name = "#nixos"; autojoin = true;}
             { name = "#nixos-chat"; autojoin = false;}
             ];
           server = {
             address = "irc.freenode.net";
             port = 6697;
             useSSL = true;
             verifySSL = true;
             autoconnect = true;
           };
         };
       };
    };

As far as I understood, irssi allows the usage of plugins to add other network types (i.e. XMPP). So far, chatnets.<name?>.type is not checked for validity.

Note that this is my first pull request, so I'd love some feedback :) I hope that I understood the syntax guidelines correctly.

irssi is a cli IRC client.
@teto
Copy link
Collaborator

teto commented Jan 25, 2019

cool though I would have preferred to see a weechat one xD

Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks good in general, I've just added a few comments.

modules/programs/irssi.nix Show resolved Hide resolved
modules/programs/irssi.nix Outdated Show resolved Hide resolved
modules/programs/irssi.nix Outdated Show resolved Hide resolved
modules/programs/irssi.nix Show resolved Hide resolved
modules/programs/irssi.nix Outdated Show resolved Hide resolved
modules/programs/irssi.nix Outdated Show resolved Hide resolved
modules/programs/irssi.nix Outdated Show resolved Hide resolved
modules/programs/irssi.nix Outdated Show resolved Hide resolved
modules/programs/irssi.nix Outdated Show resolved Hide resolved
modules/programs/irssi.nix Outdated Show resolved Hide resolved
CRTified added a commit to CRTified/home-manager that referenced this pull request Jan 28, 2019
This commit integrates the changes recommended in
nix-community#552
This commit integrates the changes recommended in
nix-community#552
@rycee
Copy link
Member

rycee commented Jan 28, 2019

Thanks! I've squashed and rebased into master in 02a5a67. I made a few slight alterations of minor things I noticed when doing the merge, like removing the unnecessary serverType and adding an example network.

@rycee rycee closed this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants