Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying starship package. #868

Closed
wants to merge 1 commit into from

Conversation

@davidtwco
Copy link
Contributor

davidtwco commented Oct 11, 2019

No description provided.

@rycee

This comment has been minimized.

Copy link
Owner

rycee commented Oct 11, 2019

Hmm, the preferred way to override packages would be to add an overlay. E.g., along the lines of

nixpkgs.overlays = [
  (self: super: {
    starship = …;
  })
];

I'm OK with having a package option if there is a strong argument for it, though.

@davidtwco

This comment has been minimized.

Copy link
Contributor Author

davidtwco commented Oct 11, 2019

I've found that it's quite easy to get Nix stuck until it consumes all your memory when creating an overlay that overrides a package (particularly when I override from the unstable channel I have pinned) - that's almost certainly me doing something wrong, but it's hard to go wrong with a package option, it's more intuitive and discoverable, IMO.

@shanesveller

This comment has been minimized.

Copy link

shanesveller commented Oct 17, 2019

There are other examples within home-manager that offer this approach too, such as programs.emacs.package. I've wound up using the overlay approach in the meantime, so I can pull starship in particular from nixpkgs-unstable channel.

@rycee

This comment has been minimized.

Copy link
Owner

rycee commented Dec 8, 2019

Fair enough! Rebased to master in 5c9ec0d.

@rycee rycee closed this Dec 8, 2019
davidtwco added a commit to davidtwco/veritas that referenced this pull request Dec 9, 2019
Signed-off-by: David Wood <david@davidtw.co>
@davidtwco davidtwco deleted the davidtwco:starship-package branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.