Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the function descriptions #74

Merged
merged 2 commits into from Aug 20, 2019
Merged

Fix typos in the function descriptions #74

merged 2 commits into from Aug 20, 2019

Conversation

ryonakano
Copy link
Member

@ryonakano ryonakano commented Aug 18, 2019

Changes Summary

  • Fix a typo: substruct to subtract
  • The words "cosinus", "sinus" seem to be a French

I'm not good at math, so I wonder why "arg tangent" is not "arc tangent" like other trigonometric functions (arc cosine and arc sine). Should we also fix this?

functions.add (new Function ("arccos", Functions.arccos, _("Gives the arc cosine of a number")));
functions.add (new Function ("arcsin", Functions.arcsin, _("Gives the arc sine of a number")));
functions.add (new Function ("arctan", Functions.arctan, _("Gives the arg tangent of a number")));

@ryonakano ryonakano requested review from elegaanz and removed request for elegaanz August 18, 2019 22:10
elegaanz
elegaanz previously approved these changes Aug 20, 2019
Copy link
Contributor

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "arg tangent" is a typo.

Otherwise 👍

@NathanBnm
Copy link
Contributor

* The words "cosinus", "sinus" seem to be a French

Sorry I though it was the same in english 😅

@NathanBnm
Copy link
Contributor

I think "arg tangent" is a typo.

Otherwise +1

I can confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants