Skip to content
Commits on Feb 7, 2013
  1. @dbussink

    Merge pull request #2143 from ryoqun/proc-subclass-new

    Don't duplicate Proc objects if not needed
    dbussink committed Feb 7, 2013
  2. Don't duplicate Proc objects if not needed

    Currently, when its receiver is a subclass of Proc, Proc::from_env() duplicates
    passed objects, even if not needed. The case is that passing instances of the
    same subclass of Proc:
    
        class MyProc < Proc
        end
        prc = Proc.new{}
        my_prc = MyProc.new(&prc)
        # => returns an instance of MyProc duplicated from prc
        MyProc.new(&my_prc)
        # => SHOULD return my_prc, but DOESN'T, rather DOES duplicate my_prc
        Proc.new(&prc)
        # => returns prc, by comparison
    
    The problem is that there is unintended code path in which the needless
    duplication can happen.
    
    Thus, the duplication logic is moved from Proc::from_env() into the ruby code
    of Proc.new and a new primitive called proc_duplicate_as_subclass.
    
    Also revert no longer valid changes done in the following commit, which
    originally tried to fix this:
    
    1abfbdf
    Make Proc::from_env reset klass if appropriate
    committed Feb 6, 2013
  3. Add failing tags

    committed Feb 6, 2013
  4. Spec ProcSubClass.new

    committed Feb 6, 2013
Commits on Feb 6, 2013
  1. @dbussink

    Fix issue with invalid reading of byte size

    The buffer isn't marked on stack and doesn't need to be since we copy
    data. This does mean however, we shouldn't read from it after we have
    possibly gc'ed. By storing the buffer size at the beginning we ensure we
    don't need to read it later.
    dbussink committed Feb 6, 2013
  2. @dbussink

    Merge pull request #2145 from ryoqun/improve-bytecode-printer

    Improve bytecode printer
    dbussink committed Feb 6, 2013
  3. @dbussink
  4. @dbussink
  5. @dbussink

    Merge pull request #2144 from ryoqun/print-bytecode-literals

    Always show actual literals in bytecode printer
    dbussink committed Feb 6, 2013
  6. Always show actual literals in bytecode printer

    Currently the keyword "literal" is used inconsistently across the bytecode
    instructions. For example, push_const uses it, but set_const doesn't.
    
    Always use "literal" to indicate the index to literals. And this enables
    Rubinius' built-in bytecode printer to show the actual literals referenced by
    the index.
    
    This would really ease my life when hacking on Rubinus, hopefully others
    starting to hack on it.
    committed Feb 6, 2013
  7. @dbussink

    Implement rb_method_boundp

    Fixes #1145
    dbussink committed Feb 6, 2013
  8. @dbussink
  9. @jc00ke

    Merge pull request #2142 from ryoqun/proc-new-comment

     Add a comment to the assembly of Proc.new
    jc00ke committed Feb 5, 2013
  10. @brixen

    Fixed Kernel.chop[!].

    brixen committed Feb 5, 2013
  11. @brixen
  12. Remove trailing white space

    committed Feb 6, 2013
Commits on Feb 5, 2013
  1. @dbussink

    Setup pipe with proper default encodings

    Fixes #2071
    dbussink committed Feb 5, 2013
  2. @dbussink
  3. @dbussink
  4. @dbussink
  5. @dbussink
  6. @dbussink

    Add spec case for complex regexp with binary encoding

    Taken from issue #1669
    dbussink committed Feb 5, 2013
  7. @dbussink

    Add global symbol for to_ary

    dbussink committed Feb 5, 2013
  8. @dbussink

    Handle signals after pthread_cond_wait is interrupted

    There might be signals that need to be run if pthread_cond_wait is
    interrupted. Fixes #2093
    dbussink committed Feb 5, 2013
Commits on Feb 4, 2013
  1. @brixen
  2. @brixen
  3. @brixen
Something went wrong with that request. Please try again.