New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline at the top of a file causes issues in eclipse. #114

Closed
lombokissues opened this Issue Jul 14, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 41)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Aug 28, 2009 at 02:18 UTC

This is a really weird one. For the full report, see this discussion on the googlegroups:

http://groups.google.com/group/project-lombok/browse_thread/thread/b19d602e8123d1e8

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Aug 28, 2009 at 02:18 UTC

This is a really weird one. For the full report, see this discussion on the googlegroups:

http://groups.google.com/group/project-lombok/browse_thread/thread/b19d602e8123d1e8

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Aug 31, 2009 at 22:59 UTC

Preliminary research: It seems that having lombok generate any method with an annotation on the method
itself (whether or not there are (generated) annotations on method parameters is not relevant) will trigger this
bug. So, that would be toString, equals, hashCode (as they also generate an @ Override), but also @ Getter for
a field that has a @ NonNull/@ NotNull/@ Nullable annotation, which gets copied over.

Much likely culprit is that the source positions of these generated annotations are not properly set. Let us pray
that no part of the eclipse backend parser architecture is too stupid to figure it out from the basic AST and
reparses. That's why most of those source positions are 0 in the first place.

Will try to fix this now.

--Roel & Reinier

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Aug 31, 2009 at 22:59 UTC

Preliminary research: It seems that having lombok generate any method with an annotation on the method
itself (whether or not there are (generated) annotations on method parameters is not relevant) will trigger this
bug. So, that would be toString, equals, hashCode (as they also generate an @ Override), but also @ Getter for
a field that has a @ NonNull/@ NotNull/@ Nullable annotation, which gets copied over.

Much likely culprit is that the source positions of these generated annotations are not properly set. Let us pray
that no part of the eclipse backend parser architecture is too stupid to figure it out from the basic AST and
reparses. That's why most of those source positions are 0 in the first place.

Will try to fix this now.

--Roel & Reinier

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Sep 01, 2009 at 19:12 UTC

Fixed in commits da36708 and
25e33d0 and 5b16055.

Will be released in v0.8.4.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Sep 01, 2009 at 19:12 UTC

Fixed in commits da36708 and
25e33d0 and 5b16055.

Will be released in v0.8.4.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Sep 01, 2009 at 22:58 UTC

Issue #107 has been merged into this issue.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Sep 01, 2009 at 22:58 UTC

Issue #107 has been merged into this issue.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Oct 16, 2009 at 08:55 UTC

Issue #111 has been merged into this issue.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Oct 16, 2009 at 08:55 UTC

Issue #111 has been merged into this issue.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment