New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lombok annotations on field declarations with multiple fields only look at the first field. #127

Closed
lombokissues opened this Issue Jul 14, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 54)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Sep 24, 2009 at 21:47 UTC

this:

private @ Getter int x, y, z;

will only generate a getter for 'x', but this:

public @ SuppressWarnings("deprecation") Date classSpec = new Date("foo"), methodName = 

new Date("foo"), methodDescriptor = new Date("foo");

clearly shows that the general theory is that the annotation is supposed to apply to every listed
field, so getters for all 3 fields should have been generated.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Sep 24, 2009 at 21:47 UTC

this:

private @ Getter int x, y, z;

will only generate a getter for 'x', but this:

public @ SuppressWarnings("deprecation") Date classSpec = new Date("foo"), methodName = 

new Date("foo"), methodDescriptor = new Date("foo");

clearly shows that the general theory is that the annotation is supposed to apply to every listed
field, so getters for all 3 fields should have been generated.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Jul 19, 2010 at 14:55 UTC

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Jul 19, 2010 at 14:55 UTC

@lombokissues lombokissues added this to the 0.9.3 milestone Jul 14, 2015

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Jul 20, 2010 at 08:47 UTC

I've confirmed that the intent of @ Foo int x, y; is indeed for that annotation to apply to both fields. Eclipse really doesn't make this easy, but we'll fix it.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Jul 20, 2010 at 08:47 UTC

I've confirmed that the intent of @ Foo int x, y; is indeed for that annotation to apply to both fields. Eclipse really doesn't make this easy, but we'll fix it.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Jul 20, 2010 at 10:01 UTC

Fixed in commit d7ee0bc - should be out in release 0.9.3 (Burrowing Whale).

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Jul 20, 2010 at 10:01 UTC

Fixed in commit d7ee0bc - should be out in release 0.9.3 (Burrowing Whale).

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment