New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either all or none of equals/hashCode/canEqual should be generated #313

Closed
lombokissues opened this Issue Jul 14, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 240)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Jul 18, 2011 at 19:02 UTC

These 3 methods are all part of the same implementation, and it makes no sense to generate only half of the methods. Either all or none should be generated (and when using @ EqualsAndHashCode, if none are generated, a warning should be emitted).

The docs already state that this is how it works, but that's not actually how it works.

Present in: 0.10.0-RC1

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Jul 18, 2011 at 19:02 UTC

These 3 methods are all part of the same implementation, and it makes no sense to generate only half of the methods. Either all or none should be generated (and when using @ EqualsAndHashCode, if none are generated, a warning should be emitted).

The docs already state that this is how it works, but that's not actually how it works.

Present in: 0.10.0-RC1

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Jul 18, 2011 at 19:14 UTC

Well, the docs were a bit vague so those have also been updated. Will be in 0.10.0-RC2

fixed in commit 83e2fb5

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Jul 18, 2011 at 19:14 UTC

Well, the docs were a bit vague so those have also been updated. Will be in 0.10.0-RC2

fixed in commit 83e2fb5

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment