New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lombok messes with Eclipse Save actions #336

Closed
lombokissues opened this Issue Jul 14, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 263)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 arcnorj   🕗 Aug 25, 2011 at 09:33 UTC

What steps will reproduce the problem?

  1. Enable "Add final modifier to private fields" in "Save Actions"
  2. Add @ Setter to any private field AND give it a default value (either in declaration or in constructor)
  3. Save

What is the expected output? What do you see instead?
"final" gets added to the field every time, as Eclipse thinks the set value is the only one used

What version of the product are you using? On what operating system?
Eclipse Indigo, Mac OSX

Please provide any additional information below.

Collaborator

lombokissues commented Jul 14, 2015

👤 arcnorj   🕗 Aug 25, 2011 at 09:33 UTC

What steps will reproduce the problem?

  1. Enable "Add final modifier to private fields" in "Save Actions"
  2. Add @ Setter to any private field AND give it a default value (either in declaration or in constructor)
  3. Save

What is the expected output? What do you see instead?
"final" gets added to the field every time, as Eclipse thinks the set value is the only one used

What version of the product are you using? On what operating system?
Eclipse Indigo, Mac OSX

Please provide any additional information below.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 arcnorj   🕗 Aug 25, 2011 at 10:14 UTC

I forgot to comment, workaround is calling the setter (not directly assigning) in your constructor, although this contributes to the clutter Lombok itself strives to avoid :P

Collaborator

lombokissues commented Jul 14, 2015

👤 arcnorj   🕗 Aug 25, 2011 at 10:14 UTC

I forgot to comment, workaround is calling the setter (not directly assigning) in your constructor, although this contributes to the clutter Lombok itself strives to avoid :P

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Sep 20, 2011 at 18:38 UTC

It'll be a long, long time before we get around to fixing this one. I know it's a bug, but it's low on our priority list and it'll be a LOT of work to fix it. Most likely at some point we'll find a universal fix for save actions and refactor scripts, and this bug wil disappear along with the rest of the problems associated with save actions.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Sep 20, 2011 at 18:38 UTC

It'll be a long, long time before we get around to fixing this one. I know it's a bug, but it's low on our priority list and it'll be a LOT of work to fix it. Most likely at some point we'll find a universal fix for save actions and refactor scripts, and this bug wil disappear along with the rest of the problems associated with save actions.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 lkwg82   🕗 Sep 21, 2011 at 12:25 UTC

can u group them with the label 'save-action-bug', to have an overview?

Collaborator

lombokissues commented Jul 14, 2015

👤 lkwg82   🕗 Sep 21, 2011 at 12:25 UTC

can u group them with the label 'save-action-bug', to have an overview?

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Nov 15, 2011 at 14:00 UTC

Should be addressed by Jappe van der Hel's work on refactors and save actions. Will be in version after 0.10.2.

Can all people affected by this give the latest edge build a whirl? Please report back here if formatting now works (or doesn't work!) You can find the edge release at:

https://projectlombok.org/download-edge.html

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Nov 15, 2011 at 14:00 UTC

Should be addressed by Jappe van der Hel's work on refactors and save actions. Will be in version after 0.10.2.

Can all people affected by this give the latest edge build a whirl? Please report back here if formatting now works (or doesn't work!) You can find the edge release at:

https://projectlombok.org/download-edge.html

@lombokissues lombokissues removed the accepted label Jul 14, 2015

@lombokissues lombokissues added this to the 0.10.3 milestone Jul 14, 2015

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Nov 21, 2011 at 23:03 UTC

Now in release 0.10.4

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Nov 21, 2011 at 23:03 UTC

Now in release 0.10.4

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Jan 10, 2012 at 00:11 UTC

Reopened. The current solution as implemented in dc92425 breaks lots of other code. See also issue #398.

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Jan 10, 2012 at 00:11 UTC

Reopened. The current solution as implemented in dc92425 breaks lots of other code. See also issue #398.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Jan 18, 2012 at 23:59 UTC

Jappe managed to provide a pull request that fixes both this and issue #398. Will be in 0.10.8.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Jan 18, 2012 at 23:59 UTC

Jappe managed to provide a pull request that fixes both this and issue #398. Will be in 0.10.8.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment