New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations are disappearing during delombok #342

Closed
lombokissues opened this Issue Jul 14, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 269)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 anthony@whitford.com   🕗 Sep 05, 2011 at 16:40 UTC

Consider the attached code.
A delombok of the code will NOT retain the @ XmlEnumValue annotations.
I expect the @ XmlEnumValue annotations to be retained during delombok.

This problem exists in 0.10.0, but I also think it existed in 0.9.3.
I can witness this problem on Windows and Mac.
I am using Java 6 update 24 and 26.

Collaborator

lombokissues commented Jul 14, 2015

👤 anthony@whitford.com   🕗 Sep 05, 2011 at 16:40 UTC

Consider the attached code.
A delombok of the code will NOT retain the @ XmlEnumValue annotations.
I expect the @ XmlEnumValue annotations to be retained during delombok.

This problem exists in 0.10.0, but I also think it existed in 0.9.3.
I can witness this problem on Windows and Mac.
I am using Java 6 update 24 and 26.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 anthony@whitford.com   🕗 Sep 05, 2011 at 16:40 UTC

🔗 AnotherDataExample.java View file

Collaborator

lombokissues commented Jul 14, 2015

👤 anthony@whitford.com   🕗 Sep 05, 2011 at 16:40 UTC

🔗 AnotherDataExample.java View file

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Sep 20, 2011 at 19:06 UTC

Delombok currently runs off of a source printer we found in the openJDK sources. It's pretty bad; this certainly isn't the first case where the printer is just wrong. We fixed it in e4bff6b but hopefully we can move to lombok.ast soon which has a much better tested printer. It got this one right, for example.

Will be in 0.10.1.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Sep 20, 2011 at 19:06 UTC

Delombok currently runs off of a source printer we found in the openJDK sources. It's pretty bad; this certainly isn't the first case where the printer is just wrong. We fixed it in e4bff6b but hopefully we can move to lombok.ast soon which has a much better tested printer. It got this one right, for example.

Will be in 0.10.1.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment