New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse "Organize imports" regression in 0.10.4 #381

Closed
lombokissues opened this Issue Jul 14, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 308)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 jwnimmer@jaybridge.com   🕗 Dec 06, 2011 at 21:18 UTC

What steps will reproduce the problem?

  1. Import the attached file into a new eclipse project.
  2. Source -> Organize Imports (Ctrl-Shift-O).
  3. Eclipse dialog with IllegalArgumentException or similar pops up.

What is the expected output? What do you see instead?

With the ﹟90 fixes in lombok 0.10.4, the eclipse formatter and code clean-up actions work much better, thank you! However, whereas previously any lombok-induced formatter failures were silent (code would sometimes fail to format, but no error dialogs) --- now there are some cases where I'm getting error dialogs all the time, such as this one.

Ideally, I'd obviously like code cleanup to run to completion without error, but I'd be content to at least return to the prior behavior of leaving the source unchanged with no error pop-ups.

FWIW, turning on Organize Imports as a save action also has this problem. (That is where I originally hit the issue.)

What version of the product are you using? On what operating system?

Lombok 0.10.4 in Eclipse 3.7.1 on Ubuntu 10.04
OpenJDK Runtime Environment (IcedTea6 1.9.9) (6b20-1.9.9-0ubuntu1~10.04.2)

Collaborator

lombokissues commented Jul 14, 2015

👤 jwnimmer@jaybridge.com   🕗 Dec 06, 2011 at 21:18 UTC

What steps will reproduce the problem?

  1. Import the attached file into a new eclipse project.
  2. Source -> Organize Imports (Ctrl-Shift-O).
  3. Eclipse dialog with IllegalArgumentException or similar pops up.

What is the expected output? What do you see instead?

With the ﹟90 fixes in lombok 0.10.4, the eclipse formatter and code clean-up actions work much better, thank you! However, whereas previously any lombok-induced formatter failures were silent (code would sometimes fail to format, but no error dialogs) --- now there are some cases where I'm getting error dialogs all the time, such as this one.

Ideally, I'd obviously like code cleanup to run to completion without error, but I'd be content to at least return to the prior behavior of leaving the source unchanged with no error pop-ups.

FWIW, turning on Organize Imports as a save action also has this problem. (That is where I originally hit the issue.)

What version of the product are you using? On what operating system?

Lombok 0.10.4 in Eclipse 3.7.1 on Ubuntu 10.04
OpenJDK Runtime Environment (IcedTea6 1.9.9) (6b20-1.9.9-0ubuntu1~10.04.2)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 jwnimmer@jaybridge.com   🕗 Dec 06, 2011 at 21:18 UTC

🔗 Foo.java View file

Collaborator

lombokissues commented Jul 14, 2015

👤 jwnimmer@jaybridge.com   🕗 Dec 06, 2011 at 21:18 UTC

🔗 Foo.java View file

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Dec 19, 2011 at 20:30 UTC

Fixed in de1bc35. Will be present in 0.10.6.

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Dec 19, 2011 at 20:30 UTC

Fixed in de1bc35. Will be present in 0.10.6.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Dec 19, 2011 at 22:04 UTC

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Dec 19, 2011 at 22:04 UTC

@lombokissues lombokissues added this to the 0.10.6 milestone Jul 14, 2015

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment