New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect placement of extracted constants with Logging annotation. #388

Closed
lombokissues opened this Issue Jul 14, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 315)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 benkelaar   🕗 Dec 12, 2011 at 15:04 UTC

What steps will reproduce the problem?

  1. Add one of the logging annotations to a class.
  2. Do extract to constant refactoring on value in class.

What is the expected output? What do you see instead?
Eclipse should create a constant at the beginning of the class (Inside the closed brackets), instead it's created at the beginning of the file, even before the package statement.

What version of the product are you using? On what operating system?
0.10.5, Eclipse in Windows.

Please provide any additional information below.
Showed it to Roel, asked me to register the issue.

Collaborator

lombokissues commented Jul 14, 2015

👤 benkelaar   🕗 Dec 12, 2011 at 15:04 UTC

What steps will reproduce the problem?

  1. Add one of the logging annotations to a class.
  2. Do extract to constant refactoring on value in class.

What is the expected output? What do you see instead?
Eclipse should create a constant at the beginning of the class (Inside the closed brackets), instead it's created at the beginning of the file, even before the package statement.

What version of the product are you using? On what operating system?
0.10.5, Eclipse in Windows.

Please provide any additional information below.
Showed it to Roel, asked me to register the issue.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Dec 19, 2011 at 20:30 UTC

Fixed in de1bc35. Will be present in 0.10.6.

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Dec 19, 2011 at 20:30 UTC

Fixed in de1bc35. Will be present in 0.10.6.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Dec 19, 2011 at 22:05 UTC

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Dec 19, 2011 at 22:05 UTC

@lombokissues lombokissues added this to the 0.10.6 milestone Jul 14, 2015

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment